fix stable release changelog to include all changes since last stable#716
fix stable release changelog to include all changes since last stable#716aviator-app[bot] merged 1 commit intomasterfrom
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
✅ FlexReview StatusCommon Owner:
Review SLO: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .goreleaser.yaml configuration to ignore nightly tags during the release process. The review feedback suggests expanding the tag exclusion regex to include other pre-release identifiers like RC, beta, and alpha to ensure that stable release changelogs are correctly generated relative to the last stable version.
|
|
||
| git: | ||
| ignore_tags: | ||
| - ".*-nightly" |
There was a problem hiding this comment.
The current regex .*-nightly only filters out tags containing -nightly. If the project uses other pre-release identifiers (such as -rc, -beta, or -alpha), those tags will still be picked up as the 'previous tag', causing the stable release changelog to be incremental rather than since the last stable version. To fully satisfy the goal of including all changes since the last stable release, consider using a more inclusive regex like .*-(nightly|rc|beta|alpha).* or .*-.* (if all pre-releases contain a hyphen). Additionally, note that this setting is global and will cause nightly releases to also show a full changelog since the last stable release, rather than just the changes since the previous nightly.
- ".*-(nightly|rc|beta|alpha).*"
2 participants
goreleaser was picking the nightly tag as the previous tag, so stable releases only showed incremental changes instead of the full changelog since last stable.