Fix 'previous failures' in watch mode always incrementing

novemberborn · novemberborn · commit db0fdb2925cb · 2024-01-28T21:33:40.000+01:00
The counters used absolute paths for the test files, but the clearing logic used relative paths. Count using relative paths instead. The number of previous failures is not observable to the test harness, so this does not come with test coverage. Fixes #3295.
diff --git a/lib/watcher.js b/lib/watcher.js
@@ -106,7 +106,8 @@ async function * plan({api, filter, globs, projectDir, providers, stdin, abortSi
 				case 'uncaught-exception':
 				case 'unhandled-rejection':
 				case 'worker-failed': {
-					failureCounts.set(evt.testFile, 1 + (failureCounts.get(evt.testFile) ?? 0));
+					const path = nodePath.relative(projectDir, evt.testFile);
+					failureCounts.set(path, 1 + (failureCounts.get(path) ?? 0));
 					break;
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,8 @@ async function * plan({api, filter, globs, projectDir, providers, stdin, abortSi`
`106`	`106`	`case 'uncaught-exception':`
`107`	`107`	`case 'unhandled-rejection':`
`108`	`108`	`case 'worker-failed': {`
`109`		`- failureCounts.set(evt.testFile, 1 + (failureCounts.get(evt.testFile) ?? 0));`
	`109`	`+ const path = nodePath.relative(projectDir, evt.testFile);`
	`110`	`+ failureCounts.set(path, 1 + (failureCounts.get(path) ?? 0));`
`110`	`111`	`break;`
`111`	`112`	`}`
`112`	`113`