Skip to content

Commit 15dddf3

Browse files
novemberbornnovemberborn
committed
Fix external-assertions snapshot for Node.js 20.11
Vary the snapshots by minor version were appropriate.
1 parent db0fdb2 commit 15dddf3

3 files changed

Lines changed: 112 additions & 12 deletions

File tree

‎test/external-assertions/snapshots/test.js.md‎

Lines changed: 103 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ The actual snapshot is saved in `test.js.snap`.
44

55
Generated by [AVA](https://avajs.dev).
66

7-
## node assertion (node.js v18)
7+
## node assertion (node.js v^18)
88

99
> Snapshot 1
1010
@@ -46,7 +46,7 @@ Generated by [AVA](https://avajs.dev).
4646
␊
4747
2 tests failed`
4848

49-
## expect error (node.js v18)
49+
## expect error (node.js v^18)
5050

5151
> Snapshot 1
5252
@@ -96,7 +96,7 @@ Generated by [AVA](https://avajs.dev).
9696
␊
9797
2 tests failed`
9898

99-
## node assertion (node.js v20)
99+
## node assertion (node.js v^20 < 20.11)
100100

101101
> Snapshot 1
102102
@@ -138,7 +138,7 @@ Generated by [AVA](https://avajs.dev).
138138
␊
139139
2 tests failed`
140140

141-
## expect error (node.js v20)
141+
## expect error (node.js v^20 < 20.11)
142142

143143
> Snapshot 1
144144
@@ -188,7 +188,7 @@ Generated by [AVA](https://avajs.dev).
188188
␊
189189
2 tests failed`
190190

191-
## node assertion (node.js v21)
191+
## node assertion (node.js v^20.11)
192192

193193
> Snapshot 1
194194
@@ -235,7 +235,104 @@ Generated by [AVA](https://avajs.dev).
235235
␊
236236
2 tests failed`
237237

238-
## expect error (node.js v21)
238+
## expect error (node.js v^20.11)
239+
240+
> Snapshot 1
241+
242+
`␊
243+
✘ [fail]: test Assertion failed␊
244+
✘ [fail]: test async Assertion failed␊
245+
─␊
246+
␊
247+
test␊
248+
␊
249+
Assertion failed: ␊
250+
␊
251+
expect(received).toBeTruthy()␊
252+
␊
253+
Received: false␊
254+
␊
255+
Error: expect(received).toBeTruthy()␊
256+
␊
257+
Received: false␊
258+
at ---␊
259+
at ---␊
260+
at ---␊
261+
at ---␊
262+
at ---␊
263+
at ---␊
264+
at ---␊
265+
at ---␊
266+
at ---␊
267+
␊
268+
␊
269+
␊
270+
test async␊
271+
␊
272+
Assertion failed: ␊
273+
␊
274+
expect(received).toBeTruthy()␊
275+
␊
276+
Received: false␊
277+
␊
278+
Error: expect(received).toBeTruthy()␊
279+
␊
280+
Received: false␊
281+
at ---␊
282+
at ---␊
283+
␊
284+
─␊
285+
␊
286+
2 tests failed`
287+
288+
## node assertion (node.js v^21)
289+
290+
> Snapshot 1
291+
292+
`␊
293+
✘ [fail]: test Assertion failed␊
294+
✘ [fail]: test async Assertion failed␊
295+
─␊
296+
␊
297+
test␊
298+
␊
299+
Assertion failed: ␊
300+
␊
301+
The expression evaluated to a falsy value:␊
302+
␊
303+
assert(false)␊
304+
␊
305+
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:␊
306+
␊
307+
assert(false)␊
308+
␊
309+
at ---␊
310+
at ---␊
311+
at ---␊
312+
at ---␊
313+
at ---␊
314+
at ---␊
315+
at ---␊
316+
at ---␊
317+
at ---␊
318+
␊
319+
␊
320+
␊
321+
test async␊
322+
␊
323+
Assertion failed: ␊
324+
␊
325+
false == true␊
326+
␊
327+
AssertionError [ERR_ASSERTION]: false == true␊
328+
at ---␊
329+
at ---␊
330+
␊
331+
─␊
332+
␊
333+
2 tests failed`
334+
335+
## expect error (node.js v^21)
239336

240337
> Snapshot 1
241338

‎test/external-assertions/snapshots/test.js.snap‎

40 Bytes
Binary file not shown.

‎test/external-assertions/test.js‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,24 @@ const snapshotStdout = (t, stdout) => {
1313
t.snapshot(normalized);
1414
};
1515

16-
const major = process.versions.node.split('.')[0];
17-
18-
for (const version of ['18', '20', '21']) {
16+
for (const [label, selector] of Object.entries({
17+
'^18': /^18\./,
18+
'^20 < 20.11': /^20\.(\d\.|10\.)/,
19+
'^20.11': /^20\.(1[1-9]\.|[2-9]\d\.)/,
20+
'^21': /^21\./,
21+
})) {
1922
// Tests need to be declared for all versions, so that snapshots can be
2023
// updated by running `npx test-ava -u test/external-assertions/test.js` for
2124
// each supported version. However only the tests for the current version
2225
// can run, so skip the others.
23-
const declare = version === major ? test : test.skip;
26+
const declare = selector.test(process.versions.node) ? test : test.skip;
2427

25-
declare(`node assertion (node.js v${version})`, async t => {
28+
declare(`node assertion (node.js v${label})`, async t => {
2629
const result = await t.throwsAsync(fixture(['assert-failure.js']));
2730
snapshotStdout(t, result.stdout);
2831
});
2932

30-
declare(`expect error (node.js v${version})`, async t => {
33+
declare(`expect error (node.js v${label})`, async t => {
3134
const result = await t.throwsAsync(fixture(['expect-failure.js']));
3235
snapshotStdout(t, result.stdout);
3336
});

0 commit comments

Comments
 (0)