Support Select GSON & Jakarta JSON-B annotations (#426) #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mechite <[email protected]>
SentryMan
requested changes
Sep 20, 2025
jsonb-generator/src/main/java/io/avaje/jsonb/generator/ValuePrism.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mechite <[email protected]>
Signed-off-by: Mechite <[email protected]>
mechite
commented
Sep 20, 2025
jsonb-generator/src/main/java/io/avaje/jsonb/generator/ValuePrism.java
Outdated
Show resolved
Hide resolved
SentryMan
requested changes
Sep 20, 2025
jsonb-generator/src/main/java/io/avaje/jsonb/generator/JsonbProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mechite <[email protected]>
Signed-off-by: Mechite <[email protected]>
Signed-off-by: Mechite <[email protected]>
Contributor
|
Is this ready for review now? |
SentryMan
approved these changes
Sep 22, 2025
Collaborator
|
even though find it pretty unlikely that anyone would publish a package using jakarta json that would need importing, it looks good to me. |
rbygrave
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for some annotations from both GSON & JSON-B, making it much smoother to swap in
avaje-jsonbinto projects using these.It also adds [3] for Jackson + support for
@JsonRawValue.Here is an outline of supported features:
@Json.Alias@JsonAlias@SerializedName(alternate=…)@Json.Creator@JsonCreator@JsonbCreator@Json.Ignore@JsonIgnore@Expose(serialize = false)[2]@JsonbTransient@Json.Property@JsonProperty@SerializedName@JsonbProperty@Json.Raw@JsonRawValue@Json.Value@JsonValue@JsonbValue[1] - Removed, see Page 35 @ JSON-B spec PDF
why this was removed I have no clue, but it should mean nobody is using it.
[2] - Gson also supports
transient(which avaje already supports).[3] - This PR also includes a check for empty string when using Jackson
JsonProperty.(wasn't sure how avaje handles this previously?)
(due to the above)
[4] - Removed in 415f286
note this pr is also my first time working with prisms
(@SentryMan — please review, and do not merge until we all agree this is a good feature to add)
It is important that the test suite is improved (#426 (review)).