Properly read all the meta annotations for package private components #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly read all the meta annotations
SentryMan
force-pushed
the
refine-pkg-private
branch
from
3fb3c25 to
f918d1e
Compare
rbygrave
changed the title
rbygrave
reviewed
Apr 29, 2025
| .findFirst() | ||
| .orElseThrow(); | ||
|
|
||
| return firstAdapter.getModifiers().contains(Modifier.PUBLIC); |
Contributor
There was a problem hiding this comment.
This matches the existing logic ... but to me isn't quite correct. It would fail if there is a Factory (generic type) but NO normal adapter (for non-generic type).
So I think there should be a followup that addresses that.
rbygrave
reviewed
Apr 29, 2025
| .forEach(componentMetaData::add); | ||
| .forEach(meta::add); | ||
|
|
||
| } else if (metaDataFactory != null) { |
Contributor
There was a problem hiding this comment.
Looks like an existing bug here ... this ONLY adds factories if there isn't MetaData but there will commonly be both @MetaData and @MetaData.JsonFactory
rbygrave
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properly read all the meta annotations