return default instance on unchanged builder #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't see a reason to return separate instances
Contributor
|
I see this as a performance optimisation, but I don't see it being a very commonly used one because factories is generally not empty, so I see as a not very useful performance optimisation? What was a motivation for this? |
Collaborator
Author
|
For Jsonb, there are a bunch of places where a default jsonb instance can get created. (inject plugin, jex default adapter, http-client default adapter) I've also got some internal libraries that create default jsonb instances via SPI |
Collaborator
Author
If there are no manually provided factories, it will be empty by the time the check happens. Otherwise that test I added would fail |
rbygrave
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't see a reason to return separate instances.
Essentially this change causes the same
Jsonbinstance to be returned by the statementJsonb.builder().build()