Skip to content

Generated code with "direct return" when no setters required #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbygrave merged 1 commit into from
Mar 15, 2025
Merged

Generated code with "direct return" when no setters required #347

rbygrave merged 1 commit into from
Mar 15, 2025

Conversation

@rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Mar 15, 2025

Instead of generating code like:

   MyType myType = new MyType(...);
   return myType;

Generate:

   return new MyType(...);

@rbygrave
Generated code with "direct return" when no setters required
aefd7c4 
Instead of generating code like:

   MyType myType = new MyType(...);
   return myType;

Generate:

   return new MyType(...);
@rbygrave rbygrave requested a review from SentryMan March 15, 2025 04:31
@rbygrave rbygrave self-assigned this Mar 15, 2025
SentryMan
SentryMan approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cinema

@rbygrave rbygrave merged commit 2a73fcc into main Mar 15, 2025
9 checks passed
@rbygrave rbygrave deleted the feature/direct-return branch March 15, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SentryMan SentryMan SentryMan approved these changes

Assignees

@rbygrave rbygrave

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbygrave @SentryMan