core: clarify suspicious condition with parentheses#521
Merged
evverx merged 1 commit intoavahi:masterfrom Nov 10, 2023
Merged
Conversation
Fixes the following cppcheck warning:
```
avahi-core/server.c:1798:8: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
if ((ret = avahi_service_name_join(n, sizeof(n), name, type, domain) < 0))
^
```
It makes avahi_server_get_group_of_service set the error code correctly.
Closes avahi#205
evverx
changed the title
evverx
force-pushed
the
cppcheck-suspicious-cond
branch
from
d9c782e to
5f5f578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following cppcheck warning:
It makes avahi_server_get_group_of_service set the error code correctly.
Closes #205