test(fwdctl): refactor CLI test setup#2037
Merged
demosdemon merged 2 commits intoJun 1, 2026
Merged
Conversation
sueun-dev
requested review from
AminR443,
RodrigoVillar,
bernard-avalabs,
demosdemon and
rkuris
as code owners
github-actions
Bot
added
the
3rd party contributor
Signed-off-by: Brandon LeBlanc <[email protected]>
demosdemon
force-pushed
the
refactor-fwdctl-cli-test-tempdir
branch
from
131cdd5 to
6d3d164
Compare
demosdemon
approved these changes
Jun 1, 2026
Contributor
|
This is great. Thanks for the refactor! |
demosdemon
added
area/cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #1545.
The fwdctl CLI tests repeated the same temporary-directory setup and simple database create/insert commands in most test cases. This keeps the tests doing the same assertions while moving that setup into small helpers.
How this works
Adds helpers for running a test with a temp dir, creating a database, and inserting a key/value pair. The individual tests now pass the temp DB path through those helpers instead of re-declaring the setup each time.
How this was tested
cargo fmt --checkcargo test -p firewood-fwdctl --test clicargo clippy -p firewood-fwdctl --test cli -- -D warningsgit diff --checkBreaking Changes