Skip to content

Use acp226.DelayExcess rather than uint64#4358

Merged
StephenButtolph merged 1 commit intomasterfrom
use-delay-excess-where-possible
Sep 29, 2025
Merged

Use acp226.DelayExcess rather than uint64#4358
StephenButtolph merged 1 commit intomasterfrom
use-delay-excess-where-possible

Conversation

@StephenButtolph
Copy link
Copy Markdown
Contributor

@StephenButtolph StephenButtolph commented Sep 29, 2025

Why this should be merged

Using the defined type reduces the number of casts required by the user and makes the code more readable.

How this works

  • UpdateDelayExcess takes in a DelayExcess (not a time)
  • DesiredDelayExcess returns a DelayExcess (not a time)

How this was tested

N/A

Need to be documented in RELEASES.md?

no

Copilot AI review requested due to automatic review settings September 29, 2025 14:46
@StephenButtolph StephenButtolph requested review from ceyonur and removed request for Copilot September 29, 2025 14:46
@StephenButtolph StephenButtolph self-assigned this Sep 29, 2025
@StephenButtolph StephenButtolph moved this to In Review 🔎 in avalanchego Sep 29, 2025
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit 8b8ac94 Sep 29, 2025
35 checks passed
@StephenButtolph StephenButtolph deleted the use-delay-excess-where-possible branch September 29, 2025 15:25
@github-project-automation github-project-automation bot moved this from In Review 🔎 to Done 🎉 in avalanchego Sep 29, 2025
joshua-kim added a commit that referenced this pull request Sep 30, 2025
@joshua-kim
Squashed commit of the following:
0dc3af0 
commit 47550e9
Author: Austin Larson <[email protected]>
Date:   Mon Sep 29 11:24:22 2025 -0400

    Add generics to x/sync (#4275)

commit 8b8ac94
Author: Stephen Buttolph <[email protected]>
Date:   Mon Sep 29 11:08:40 2025 -0400

    Use `acp226.DelayExcess` rather than `uint64` (#4358)

commit 32806e0
Author: Geoff Stuart <[email protected]>
Date:   Fri Sep 26 16:40:10 2025 -0400

    Support all validator set diffs by height (#4342)

    Signed-off-by: Geoff Stuart <[email protected]>
    Co-authored-by: Stephen Buttolph <[email protected]>

commit 57a308a
Author: Jonathan Oppenheimer <[email protected]>
Date:   Fri Sep 26 13:42:10 2025 -0400

    Set `activationTime` equal to `upgrade.InitiallyActiveTime` for `propservm` (#4351)

    Signed-off-by: Jonathan Oppenheimer <[email protected]>
    Co-authored-by: Stephen Buttolph <[email protected]>

commit d57e124
Author: Joshua Kim <[email protected]>
Date:   Fri Sep 26 13:29:20 2025 -0400

    Remove UptimeManager#IsConnected (#4333)

    Signed-off-by: Joshua Kim <[email protected]>

commit 0985c16
Author: Geoff Stuart <[email protected]>
Date:   Fri Sep 26 11:19:34 2025 -0400

    Implement GetProposedHeight API in Proposervm (#4222)

    Signed-off-by: Michael Kaplan <[email protected]>
    Co-authored-by: ylg <[email protected]>
    Co-authored-by: Michael Kaplan <[email protected]>
    Co-authored-by: Stephen Buttolph <[email protected]>
    Co-authored-by: Michael Kaplan <[email protected]>

commit dfdd6a7
Author: aaronbuchwald <[email protected]>
Date:   Fri Sep 26 10:07:08 2025 -0400

    Update daily re-execution benchmark (#4340)

commit d8aa95f
Author: letreturn <[email protected]>
Date:   Fri Sep 26 22:12:02 2025 +0800

    Typo Fixes (#4353)

    Signed-off-by: letreturn <[email protected]>

commit dbbfa66
Author: rodrigo <[email protected]>
Date:   Fri Sep 26 00:02:29 2025 -0400

    fix(load): only modify non-reserved slots (#4283)

commit d0bcd73
Author: Stephen Buttolph <[email protected]>
Date:   Thu Sep 25 16:46:19 2025 -0400

    Replace `mockable.MaxTime` with `upgrade.UnscheduledActivationTime` (#4322)

commit 23c5718
Author: Stephen Buttolph <[email protected]>
Date:   Thu Sep 25 15:20:33 2025 -0400

    Refactor Warp Verification Tests (#4335)

commit cc72910
Author: Stephen Buttolph <[email protected]>
Date:   Thu Sep 25 15:16:19 2025 -0400

    Remove premature optimization in validator manager (#4346)

commit 36baa05
Author: Austin Larson <[email protected]>
Date:   Thu Sep 25 14:38:53 2025 -0400

    Granite ACP-176 (#4336)

commit d74d90c
Author: rodrigo <[email protected]>
Date:   Thu Sep 25 14:38:42 2025 -0400

    refactor(metervm): remove mockable clock (#4338)

Signed-off-by: Joshua Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanOppenheimer JonathanOppenheimer JonathanOppenheimer approved these changes

@alarso16 alarso16 alarso16 approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur

Assignees

@StephenButtolph StephenButtolph

Labels

None yet

Projects

avalanchego
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StephenButtolph @JonathanOppenheimer @alarso16