Merged
Conversation
alarso16
force-pushed
the
alarso16/db-verify
branch
from
83e15dc to
9ab50fe
Compare
alarso16
requested review from
StephenButtolph,
joshua-kim and
rrazvan1
as code owners
joshua-kim
changed the title
alarso16
commented
Sep 5, 2025
| // which means [workItem.end] isn't Nothing. Contradiction. | ||
| lastReceivedKey := largestHandledKey.Value() | ||
|
|
||
| if len(endProof) == 0 { |
Contributor
Author
There was a problem hiding this comment.
All changes this line and below are cut-and-paste from x/sync/manager.go
Contributor
There was a problem hiding this comment.
Ok, but why do we still keep comments about external stuff (like workItem)?
| require.NoError(db.Put([]byte{0x13}, []byte{3})) | ||
|
|
||
| ctx := context.Background() | ||
| syncer, err := NewManager(ManagerConfig{ |
Contributor
Author
There was a problem hiding this comment.
All these tests that don't require the manager will be moved to a different package eventually
alarso16
force-pushed
the
alarso16/db-verify
branch
from
3f6b925 to
582d1e1
Compare
alarso16
force-pushed
the
alarso16/db-verify
branch
from
582d1e1 to
c48fa13
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves proof verification and handling logic from the x/sync package to the x/merkledb package. The main purpose is to improve separation of concerns by moving database-specific operations closer to the database implementation and simplifying the sync manager interface.
- Removes database configuration attributes (hasher, tokenSize, BranchFactor) from sync manager and uses database methods instead
- Moves range proof verification and findNextKey functionality to database methods
- Updates proof marshaling to use binary format instead of protobuf in tests
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| x/sync/sync_test.go | Updates tests to call database methods directly instead of sync manager methods |
| x/sync/network_server_test.go | Changes proof marshaling from protobuf to binary format |
| x/sync/manager.go | Removes database configuration fields and moves proof handling to database |
| x/sync/client_test.go | Updates proof handling to use binary marshaling |
| x/merkledb/proof_test.go | Adds maxLength parameter to proof verification methods |
| x/merkledb/proof.go | Updates proof methods to use internal protobuf marshaling |
| x/merkledb/history_test.go | Adds maxLength parameter to verification calls |
| x/merkledb/db_test.go | Updates database tests with new return values from commit methods |
| x/merkledb/db.go | Implements proof verification and findNextKey methods in database |
| proto/sync/sync.proto | Removes unused gRPC service definitions and related messages |
| proto/pb/sync/sync.pb.go | Generated code reflecting protobuf changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alarso16
force-pushed
the
alarso16/delete-g_db
branch
from
f51a039 to
8e1c529
Compare
alarso16
force-pushed
the
alarso16/db-verify
branch
from
c48fa13 to
942f6da
Compare
demosdemon
reviewed
Sep 10, 2025
alarso16
force-pushed
the
alarso16/db-verify
branch
from
942f6da to
f6fa493
Compare
joshua-kim
reviewed
Sep 11, 2025
joshua-kim
approved these changes
Sep 11, 2025
rrazvan1
reviewed
Sep 15, 2025
rrazvan1
reviewed
Sep 15, 2025
rrazvan1
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Some of the manager attributes (e.g. hasher, tokenSize) really belong to the database. Additionally, the manager explicitly uses merkledb proof fields for range proof verification and finding the next key.
How this works
Moves range proof verification to a database method. The entire find next key functionality is also moved, with a subtle change to
completeWorkItem. All the proto changes are related to the gRPC stuff inx/sync/g_dbHow this was tested
Existing UT
Need to be documented in RELEASES.md?
No