Simplex QuorumCertificate and BLS aggregator by samliok · Pull Request #4091 · ava-labs/avalanchego

samliok · 2025-07-16T13:52:12Z

Why this should be merged

Implements the simplex QuorumCertificate, QCDeserializer and SignatureAggregator interfaces. This allows simplex to parse, aggregate and verify quorum certificates(ex. finalizations and notarizations) during execution.

How this works

Builds on top of the BLSVerifier to handle BLS signatures and public keys.
The bytes of a QC are serialized with the Codec

How this was tested

Added unit tests to qc_test.go.

Need to be documented in RELEASES.md?

no

StephenButtolph

I didn't review the tests yet, will look though the tests after these are addressed.

StephenButtolph · 2025-07-21T20:16:15Z

+// Verify checks if the quorum certificate is valid by verifying the aggregated signature against the signers' public keys.
+func (qc *QC) Verify(msg []byte) error {
+	pks := make([]*bls.PublicKey, 0, len(qc.signers))
+	quorum := simplex.Quorum(len(qc.verifier.nodeID2PK))
+	if len(qc.signers) != quorum {
+		return fmt.Errorf("%w: expected %d signers but got %d", errUnexpectedSigners, quorum, len(qc.signers))
+	}


Are there checks somewhere else that verify that the same signer isn't included multiple times?

If so we should document that assumption here. If not we need to add that.

Simplex checks for:

Finalization

Notarization

Empty notarization

During the regular Simplex admission path.

Though now when I quickly skimmed through the code, I think we can process an un-verified notarization through the replication path, oops... @samliok can you confirm?

I think we should be prudent and double check this here in the avalanchego side as well.

So a couple notes after looking a bit deeper.

We do check if multiple nodes have signed twice in simplex see here. Although it's probably a better idea to do it here in Verify(and potentially remove the check in simplex)?

We don't verify notarizations through the replication path. Created an issue

Noticed we don't add re-add replication task if block verification fails. Issue

We may possible add a signature for the wrong digest when creating a notarization. Issue

I'll tackle these issues on this simplex side, plus added checking for double signers in avalanchego.

But it seems to me that we call verifyQuorumRound whenever we process a replication response, which calls IsFinalizationValid and it performs the duplicity checks.

Let's double check the QC is valid (no double signing, enough signers) here as well.

StephenButtolph

trivial nit and lgtm

commit 45df9e6 Author: Jonathan Oppenheimer <[email protected]> Date: Tue Jul 29 15:44:08 2025 -0400 chore: Update header year to 2025 (#4140) commit dca17fd Author: Stephen Buttolph <[email protected]> Date: Tue Jul 29 15:41:14 2025 -0400 Remove gitignore line that ignores the `database/dbtest` package (#4142) commit 6e56650 Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 14:29:42 2025 -0400 Remove flaky dial throttler tests (#4139) commit 577820e Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 13:25:27 2025 -0400 Add runner input to run c-chain reexecution benchmark on arbitrary target (#4121) Signed-off-by: aaronbuchwald <[email protected]> Co-authored-by: Copilot <[email protected]> commit d5cdc50 Author: Stephen Buttolph <[email protected]> Date: Tue Jul 29 13:24:13 2025 -0400 With golangci-lint v2.2.2 using http.NewRequest is discouraged (#4136) commit d9d6f59 Author: aaronbuchwald <[email protected]> Date: Tue Jul 29 11:49:26 2025 -0400 Remove external-data-json-path from benchmark push step (#4134) commit 0c62370 Author: aaronbuchwald <[email protected]> Date: Mon Jul 28 14:12:02 2025 -0400 Split action benchmark comparison and push to gh-pages (#4130) commit b1433fd Author: Geoff Stuart <[email protected]> Date: Fri Jul 25 14:50:16 2025 -0400 Enable Cubist Signer integration (#3965) Signed-off-by: Geoff Stuart <[email protected]> Signed-off-by: Joshua Kim <[email protected]> Co-authored-by: Richard Pringle <[email protected]> Co-authored-by: Joshua Kim <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> commit 44c79a8 Author: rodrigo <[email protected]> Date: Fri Jul 25 10:52:17 2025 -0400 refactor: remove load 1.0 (#4112) commit e658cf4 Author: jishudashu <[email protected]> Date: Fri Jul 25 22:50:43 2025 +0800 refactor: use maps.Copy for cleaner map handling (#4119) Signed-off-by: jishudashu <[email protected]> commit 0980edf Author: aaronbuchwald <[email protected]> Date: Thu Jul 24 16:13:30 2025 -0400 Update codeowners of reexecution changes (#4116) commit 44b1e6c Author: Sam Liokumovich <[email protected]> Date: Thu Jul 24 16:00:45 2025 -0400 Simplex QuorumCertificate and BLS aggregator (#4091) commit 5af69e6 Author: rodrigo <[email protected]> Date: Thu Jul 24 13:17:48 2025 -0400 ci: remove load 1.0 (#4106) commit 12b75d4 Author: aaronbuchwald <[email protected]> Date: Wed Jul 23 13:01:42 2025 -0400 Add step to push benchmark results to gh-pages (#4103) Signed-off-by: aaronbuchwald <[email protected]> commit c712437 Author: Sam Liokumovich <[email protected]> Date: Wed Jul 23 11:33:29 2025 -0400 Remove Stale References of the toEngine Channel (#4101) Signed-off-by: Joshua Kim <[email protected]>

Copilot AI review requested due to automatic review settings July 16, 2025 13:52

samliok requested a review from StephenButtolph as a code owner July 16, 2025 13:52

github-project-automation bot added this to avalanchego Jul 16, 2025

This comment was marked as outdated.

Sign in to view

Add simplex QC and BLS Aggregator + tests

76629dd

samliok force-pushed the simplex-quorum branch from 3cfdc9c to 76629dd Compare July 16, 2025 13:55

samliok added 2 commits July 16, 2025 09:58

merge conflicts

de08c8c

consistent error

f4fd1ee

yacovm reviewed Jul 16, 2025

View reviewed changes

Comment thread simplex/quorum.go Outdated

Comment thread simplex/quorum.go Outdated

Comment thread simplex/quorum.go Outdated

Comment thread simplex/quorum.go Outdated

Comment thread simplex/quorum.go Outdated

samliok added 3 commits July 16, 2025 16:11

rename

1b4f583

use pointers

b4f082c

use codec.marshalling

1df2a5b

samliok commented Jul 16, 2025

View reviewed changes

Comment thread simplex/qc.go Outdated

remove register type

e092d2e

yacovm previously approved these changes Jul 16, 2025

View reviewed changes

samliok and others added 2 commits July 18, 2025 11:32

inline check

041faeb

Merge branch 'master' into simplex-quorum

d9c800e

StephenButtolph reviewed Jul 21, 2025

View reviewed changes

use canoto

63eb798

samliok and others added 4 commits July 22, 2025 17:14

duplicate signers, fixed byte array, dont copy bls verifier

4a423ba

lint

2a037aa

ensure converting to id doesn't panic

5ad5888

Merge branch 'master' into simplex-quorum

b2811dc

StephenButtolph reviewed Jul 23, 2025

View reviewed changes

add bitset, use set and nits

a4607d3

samliok force-pushed the simplex-quorum branch from d2c0b17 to a4607d3 Compare July 23, 2025 18:22

samliok added 3 commits July 23, 2025 15:11

update invalid bytes test

bff95df

table test for aggregate

9081e23

nit

c184eee

samliok and others added 6 commits July 23, 2025 15:27

Merge branch 'master' into simplex-quorum

976b2d8

nit

d932d79

nit

2105fb6

order of signers

0094c69

move test to table test

9b1c075

nit

996dd0c

yacovm reviewed Jul 24, 2025

View reviewed changes

Comment thread simplex/bls.go Outdated

Comment thread simplex/qc.go

Comment thread simplex/qc.go

Comment thread simplex/qc.go

Comment thread simplex/qc.go Outdated

Comment thread simplex/qc.go

Comment thread simplex/qc_test.go Outdated

Comment thread simplex/qc_test.go

samliok and others added 2 commits July 24, 2025 12:09

add test for filter nodes, and nits

901cb33

Merge branch 'master' into simplex-quorum

18539eb

samliok self-assigned this Jul 24, 2025

yacovm approved these changes Jul 24, 2025

View reviewed changes

StephenButtolph approved these changes Jul 24, 2025

View reviewed changes

Comment thread simplex/qc.go Outdated

nit

c877428

StephenButtolph enabled auto-merge July 24, 2025 19:46

StephenButtolph added this pull request to the merge queue Jul 24, 2025

Merged via the queue into master with commit 44b1e6c Jul 24, 2025
29 checks passed

StephenButtolph deleted the simplex-quorum branch July 24, 2025 20:16

github-project-automation bot moved this to Done 🎉 in avalanchego Jul 24, 2025

Conversation

samliok commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

How this was tested

Need to be documented in RELEASES.md?

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenButtolph left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenButtolph Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

yacovm Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samliok Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yacovm Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenButtolph left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

samliok commented Jul 16, 2025 •

edited

Loading

yacovm Jul 21, 2025 •

edited

Loading

samliok Jul 22, 2025 •

edited

Loading