Skip to content

Add WritePrometheusServiceDiscoveryConfigFile helper#4072

Merged
aaronbuchwald merged 8 commits intomasterfrom
aaronbuchwald/write-prometheus-sd-files
Jul 16, 2025
Merged

Add WritePrometheusServiceDiscoveryConfigFile helper#4072
aaronbuchwald merged 8 commits intomasterfrom
aaronbuchwald/write-prometheus-sd-files

Conversation

@aaronbuchwald
Copy link
Copy Markdown
Collaborator

@aaronbuchwald aaronbuchwald commented Jul 10, 2025

This PR adds a helper to write a prometheus service discovery config file into the expected location within ~/.tmpnet.

This is used within #4019 to write the new config file using the existing tmpnet <-> prometheus integration.

aaronbuchwald
aaronbuchwald commented Jul 10, 2025
View reviewed changes
Comment thread tests/load/prometheus.go
@aaronbuchwald aaronbuchwald marked this pull request as ready for review July 10, 2025 20:14
@aaronbuchwald aaronbuchwald requested a review from maru-ava as a code owner July 10, 2025 20:14
RodrigoVillar
RodrigoVillar reviewed Jul 10, 2025
View reviewed changes
Comment thread tests/prometheus_server.go
Comment thread tests/prometheus_server.go Outdated
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
@aaronbuchwald aaronbuchwald enabled auto-merge July 11, 2025 14:56
Elvis339
Elvis339 approved these changes Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Elvis339 Elvis339 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for separating Prometheus server from load.

We should brainstorm a bit and consider exposing monitoring service (Prometheus) rather than using it from tmpnet.

maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
Comment thread tests/prometheus_server.go
Comment thread tests/prometheus_server.go
Comment thread tests/prometheus_server.go Outdated
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
Comment thread tests/prometheus_server.go Outdated
Comment thread tests/load2/main/main.go
Comment thread tests/load/c/main/main.go
@maru-ava
Copy link
Copy Markdown
Contributor

maru-ava commented Jul 15, 2025

We should brainstorm a bit and consider exposing monitoring service (Prometheus) rather than using it from tmpnet.

Why?

aaronbuchwald
aaronbuchwald commented Jul 15, 2025
View reviewed changes
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/prometheus_server.go Outdated
maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/load2/main/main.go
maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
maru-ava
maru-ava reviewed Jul 15, 2025
View reviewed changes
Comment thread tests/fixture/tmpnet/monitor_processes.go Outdated
@aaronbuchwald aaronbuchwald mentioned this pull request Jul 16, 2025
Closed
@aaronbuchwald aaronbuchwald added this pull request to the merge queue Jul 16, 2025
Merged via the queue into master with commit 6af7dec Jul 16, 2025
29 checks passed
@aaronbuchwald aaronbuchwald deleted the aaronbuchwald/write-prometheus-sd-files branch July 16, 2025 16:06
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RodrigoVillar RodrigoVillar RodrigoVillar approved these changes

@maru-ava maru-ava maru-ava approved these changes

+1 more reviewer

@Elvis339 Elvis339 Elvis339 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

avalanchego
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aaronbuchwald @maru-ava @Elvis339 @RodrigoVillar