Skip to content

Add default validator set function to snowtest.context#4065

Merged
maru-ava merged 2 commits intomasterfrom
default-empty-validator-set
Jul 9, 2025
Merged

Add default validator set function to snowtest.context#4065
maru-ava merged 2 commits intomasterfrom
default-empty-validator-set

Conversation

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor

@JonathanOppenheimer JonathanOppenheimer commented Jul 9, 2025

Why this should be merged

The old ValidatorState in NewContext was set by default to return nil for GetValidatorSetF. This behavior was not replicated in snowtest.Context and these empty default needs to be available to many tests in subnet-evm.

How this works

Returns nil for the get validator function.

Need to be documented in RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer changed the title Add default validator set functions to snowtest.context Add default validator set function to snowtest.context Jul 9, 2025
@JonathanOppenheimer JonathanOppenheimer moved this to Ready 🚦 in avalanchego Jul 9, 2025
Copy link
Copy Markdown
Contributor

@StephenButtolph StephenButtolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshua-kim joshua-kim added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2025
@maru-ava maru-ava added this pull request to the merge queue Jul 9, 2025
Merged via the queue into master with commit bff57fe Jul 9, 2025
29 checks passed
@maru-ava maru-ava deleted the default-empty-validator-set branch July 9, 2025 16:37
@github-project-automation github-project-automation bot moved this from Ready 🚦 to Done 🎉 in avalanchego Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants