Merged
Conversation
joshua-kim
force-pushed
the
xsvm-connectrpc
branch
from
50b571e to
1749e21
Compare
joshua-kim
commented
Jun 25, 2025
| func (s *server) RegisterChain(chainName string, ctx *snow.ConsensusContext, vm common.VM) { | ||
| ctx.Lock.Lock() | ||
| handlers, err := vm.CreateHandlers(context.TODO()) | ||
| handler, err := vm.NewHTTPHandler(context.TODO()) |
Contributor
Author
There was a problem hiding this comment.
We also did a rename, which I can also undo. But since we're already messing with this interface signature it seemed forgivable to try to sneak in.
| - name: go-grpc | ||
| out: pb | ||
| opt: paths=source_relative | ||
| - plugin: connect-go |
Contributor
Author
There was a problem hiding this comment.
We need to compile our connectrpc stuff with this plugin - so for now I think separate buf modules are the cleanest way to do this. I think ideally it's all under proto, so we'd have a dir structure like proto/connect and proto/everythingelse, but if we do a move in this PR it's going to make the diff huge so I made them both top-level dirs for this PR and I think we should do the move under a single proto dir in a follow-up.
joshua-kim
added
the
DO NOT MERGE
joshua-kim
force-pushed
the
xsvm-connectrpc
branch
from
344bf5a to
f674cc5
Compare
joshua-kim
commented
Jun 25, 2025
maru-ava
approved these changes
Jun 25, 2025
Contributor
maru-ava
left a comment
maru-ava
left a comment
There was a problem hiding this comment.
Flake and e2e changes lgtm
joshua-kim
force-pushed
the
xsvm-connectrpc
branch
9 times, most recently
from
d7153f7 to
5d62147
Compare
joshua-kim
force-pushed
the
xsvm-connectrpc
branch
from
5d62147 to
66592c7
Compare
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
xsvm-connectrpc
branch
from
66592c7 to
0fc4e2c
Compare
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Joshua Kim <[email protected]>
StephenButtolph
approved these changes
Jul 11, 2025
joshua-kim
removed
the
DO NOT MERGE
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We currently decouple our routers across protocols, but this doesn't support connectrpc which is agnostic to protocols, and wants to handle h1 + h2.
How this works
How this was tested
CI passes
Need to be documented in RELEASES.md?
Yes