Document acp-118 message verification#3925
Merged
StephenButtolph merged 1 commit intomasterfrom May 1, 2025
Merged
Conversation
joshua-kim
approved these changes
May 1, 2025
michaelkaplan13
approved these changes
May 1, 2025
yacovm
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There was some confusion around if
acp118.Verifierwas expected to validate theNetworkIDandSourceChainIDfields in the message. This documents that this verification is not expected.How this works
Adds a couple comments.
How this was tested
N/A
Need to be documented in RELEASES.md?
No.