Skip to content

Add git to nix packages#3912

Merged
joshua-kim merged 1 commit intomasterfrom
add-git-for-nix
Apr 28, 2025
Merged

Add git to nix packages#3912
joshua-kim merged 1 commit intomasterfrom
add-git-for-nix

Conversation

@StephenButtolph
Copy link
Copy Markdown
Contributor

Why this should be merged

After running nix develop and then ./scripts/run_task build I ran into:

$ ./scripts/run_task.sh build
task: [build] ./scripts/build.sh
error: tool 'git' not found
task: Failed to run task "build": exit status 1

After adding git to the required packages and re-running nix develop and then ./scripts/run_task build, the build succeeded without issue.

How this works

Adds git as a dependent package in nix.

How this was tested

Locally

Need to be documented in RELEASES.md?

No

Copy link
Copy Markdown
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshua-kim joshua-kim enabled auto-merge April 25, 2025 17:57
@joshua-kim joshua-kim added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit 70bb883 Apr 28, 2025
24 checks passed
@joshua-kim joshua-kim deleted the add-git-for-nix branch April 28, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants