Fix flake TestIngressConnCount#3799
Merged
StephenButtolph merged 1 commit intoava-labs:masterfrom Mar 13, 2025
Merged
Conversation
maru-ava
approved these changes
Mar 13, 2025
The test spawns three instances of test network one after the other. In an overwhelming number of cases, they connect to each other according to their order of creation. However, in some rare cases, they connect to each other out of order. I made the test use set semantics instead of list semantics in order to not rely on their order of creation. Signed-off-by: Yacov Manevich <[email protected]>
StephenButtolph
approved these changes
Mar 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cam-schultz
pushed a commit
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Yacov Manevich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The test spawns three instances of test network one after the other. In an overwhelming number of cases, they connect to each other according to their order of creation.
However, in some rare cases, they connect to each other out of order.
I made the test use set semantics instead of list semantics in order to not rely on their order of creation.
How this works
Unit test flake fix
How this was tested
Hopefully it won't flake in CI anymore
Need to be documented in RELEASES.md?
No.