Timely halt Avalanche engine#3792
Merged
aaronbuchwald merged 1 commit intoava-labs:masterfrom Mar 12, 2025
Merged
Conversation
Signed-off-by: Yacov Manevich <[email protected]>
StephenButtolph
approved these changes
Mar 12, 2025
aaronbuchwald
approved these changes
Mar 12, 2025
cam-schultz
pushed a commit
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Yacov Manevich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Without this PR, the Avalanche bootstrapper doesn't stop its operation when the node shutdown operation is invoked.
How this works
The avalanche bootstrapper relies on an internal haltable check, which was not used after refactoring that took place in #3406.
I simply re-wired the aforementioned haltable check to the haltable that was added in #3406.
How this was tested
I wiped out the
~/.avalanchegodirectory and bootstrapped an avalanchego Fuji node, and pressed ctrl+C when it started replicating the P and X chains and made sure it halted immediately.Need to be documented in RELEASES.md?
No.