[testing] Provide more logging context for SynchronizedBeforeSuite#3741
Merged
[testing] Provide more logging context for SynchronizedBeforeSuite#3741
Conversation
Logging configuration intentionally excludes some details to account for ginkgo providing that context automatically. But in the case of event handlers like SynchronizedBeforeSuite, that automatic context is missing. To account for that, provide a logger with full output to SynchronizedBeforeSuite.
yacovm
approved these changes
Feb 24, 2025
qdm12
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Logging configuration intentionally excludes some details to account for ginkgo providing that context automatically. But in the case of event handlers like SynchronizedBeforeSuite, that automatic context is missing. To account for that, provide a logger with full output to SynchronizedBeforeSuite.
How this was tested
Manual inspection of log output
Need to be documented in RELEASES.md?
N/A