[ci] Fix metrics link annotation emitted for e2e and upgrade jobs#3713
Merged
StephenButtolph merged 1 commit intomasterfrom Feb 11, 2025
Merged
[ci] Fix metrics link annotation emitted for e2e and upgrade jobs#3713StephenButtolph merged 1 commit intomasterfrom
StephenButtolph merged 1 commit intomasterfrom
Conversation
Previously, the upgrade job was configured to filter the metrics link annotation with `network_owner=avalanchego-e2e`. Not sure how it ended up that way, because only the e2e job should be so filtered. This was preventing the metrics link for both jobs from displaying results properly. This didn't effect links emitted as part of network start, only the link emitted as an annotation. Also updated tmpnet README to better document the dashboard link annotation.
maru-ava
force-pushed
the
ci-fix-metrics-annotation
branch
from
36555ed to
e962eef
Compare
StephenButtolph
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Previously, the upgrade job was configured to filter the metrics link annotation with
network_owner=avalanchego-e2e. Not sure how it ended up that way, because only the e2e job should be so filtered. This was preventing the metrics link for both jobs from displaying results properly. This didn't effect links emitted as part of network start, only the link emitted as an annotation.How this works
filter_by_ownerarg from the upgrade to the e2e jobHow this was tested
CI
Need to be documented in RELEASES.md?
N/A