Merged
Conversation
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Jan 30, 2025
| } | ||
|
|
||
| // Add should error if adding to the mempool errors | ||
| func TestGossipMempoolAddError(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
This test seems to just test the invariants of the mempool (too big/max size/etc) so I removed it since similar coverage exists elsewhere in this package
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Jan 30, 2025
|
|
||
| tests := []test{ | ||
| { | ||
| name: "can't add transaction to mempool", |
Contributor
Author
There was a problem hiding this comment.
Similarly this test I also don't know if we want to keep... if we wanted to keep what this was intended to test we would probably want to add tests for the same mempool invariants described earlier
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
rrazvan1
reviewed
Feb 3, 2025
Signed-off-by: Joshua Kim <[email protected]>
rrazvan1
approved these changes
Feb 6, 2025
Contributor
rrazvan1
left a comment
rrazvan1
left a comment
There was a problem hiding this comment.
LGTM
(maybe we can improve these tests with my suggestions in another PR)
StephenButtolph
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes the usage of the mempool mock which makes tests brittle and difficult to reason about
How this works
Removes usage of mock and replaces it with the usage of the concrete mempool
How this was tested
UTs
Need to be documented in RELEASES.md?
No