Support UnmarshalJSON for ExporterType#3565
Merged
StephenButtolph merged 10 commits intoava-labs:masterfrom Apr 30, 2025
Merged
Support UnmarshalJSON for ExporterType#3565StephenButtolph merged 10 commits intoava-labs:masterfrom
ExporterType#3565StephenButtolph merged 10 commits intoava-labs:masterfrom
Conversation
aaronbuchwald
approved these changes
Nov 22, 2024
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
StephenButtolph
changed the title
ExporterTypeExporterType
StephenButtolph
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, if you try calling
json.Marshal()andjson.Unmarshal()on a field of typeExporterType, this will fail as, when unmarshaling, it will try to convert a string (e.g."grpc","http","unknown") into a byte.This is solved by adding a useful default value to the type and implementing
UnmarshalJSON.How this works
This PR fixes the above by adding an
UnmarshalJSON(), which handles conversions from the strings mentioned above to their respectiveExporterTypevalue.How this was tested
Added unit tests.
Need to be documented in RELEASES.md?
Modified configs have been documented.