Skip to content

Add support for VM HTTP2 handlers#3294

Merged
StephenButtolph merged 71 commits intomasterfrom
cmux
Jun 6, 2025
Merged

Add support for VM HTTP2 handlers#3294
StephenButtolph merged 71 commits intomasterfrom
cmux

Conversation

@joshua-kim
Copy link
Copy Markdown
Contributor

@joshua-kim joshua-kim commented Aug 14, 2024 •
edited
Loading

Why this should be merged

Adds native support for GRPC services being registered over the avalanchego http server. This adds support for streaming via grpc as an alternative to websockets.

How this works

  1. Uses h2c's http handler to support plaintext http2
  2. Makes a change to rpcchainvm to fix a bug where headers that are updated in the plugin process are not reflected on avalanchego's side by returning a response at the end of the Handle rpc that includes headers
  3. Introduces a new rpc for the http request request.Body so that the plugin process can stream the body instead of the current behavior which uses io.ReadAll which may not be possible in the case of a streaming rpc.

How this was tested

Added a e2e test for unary + streaming rpcs over rpcchainvm

@joshua-kim joshua-kim force-pushed the cmux branch 5 times, most recently from 56ba07f to a67b617 Compare August 22, 2024 18:38
@joshua-kim joshua-kim changed the title wip Add support for VM gRPC services Sep 3, 2024
joshua-kim
joshua-kim commented Sep 3, 2024
View reviewed changes
Comment thread proto/http/http.proto
joshua-kim
joshua-kim commented Sep 4, 2024
View reviewed changes
Comment thread proto/platform/platform.proto Outdated
@joshua-kim joshua-kim force-pushed the cmux branch 2 times, most recently from e59b451 to e0a43d2 Compare September 4, 2024 14:41
joshua-kim
joshua-kim commented Sep 4, 2024
View reviewed changes
Comment thread vms/rpcchainvm/ghttp/http_client.go Outdated
@joshua-kim joshua-kim self-assigned this Sep 4, 2024
@joshua-kim joshua-kim added the enhancement New feature or request label Sep 4, 2024
@joshua-kim joshua-kim marked this pull request as ready for review September 4, 2024 15:09
yacovm
yacovm reviewed Sep 4, 2024
View reviewed changes
Comment thread api/server/grpc_router.go Outdated
marun
marun reviewed Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to elaborate as to the motivation for this addition? The current 'why this should be merged' in the description seems more like 'what'.

Comment thread snow/engine/enginetest/vm.go
Comment thread vms/example/xsvm/grpc_service.go Outdated
Comment thread vms/rpcchainvm/ghttp/http_client.go Outdated
Comment thread vms/rpcchainvm/vm_client.go Outdated
Comment thread vms/rpcchainvm/vm_server.go Outdated
Comment thread tests/e2e/vms/xsvm.go Outdated
Comment thread tests/e2e/vms/xsvm.go
@joshua-kim
Copy link
Copy Markdown
Contributor Author

joshua-kim commented Sep 4, 2024

Would it be possible to elaborate as to the motivation for this addition? The current 'why this should be merged' in the description seems more like 'what'.

Added

@marun
Copy link
Copy Markdown
Contributor

marun commented Sep 4, 2024

The upgrade failure is legit - I'm guessing you might need to rebase?

From the logs:

[09-04|15:26:54.904] FATAL chains/manager.go:392 error creating required chain {"subnetID": "11111111111111111111111111111111LpoYY", "chainID": "2BhsWVwQzJL67dSHQfkJ9hEgv79RPURVGeAzmmyeRkkX4tyn8A", "vmID": "mgj786NP7uDwBCcq6YwThhaN8FLyybkCa4zBWTQbNgmK6k9A6", "error": "error while creating new snowman vm database contains incompatible genesis (have ed752c73b66a9c010be62b2cec0088e9e120e6bdd7680fcec50bf880a0b13a87, new 751020f3cac7bf223d5754fef14810191c6669f758a2eb10be17dd31d43e81f2)"}

@joshua-kim
Copy link
Copy Markdown
Contributor Author

joshua-kim commented Sep 4, 2024 •
edited
Loading

The upgrade failure is legit - I'm guessing you might need to rebase?

I think my coreth branch fell behind master. Gonna rebase my coreth branch again.

@joshua-kim joshua-kim mentioned this pull request Sep 11, 2024
Merged
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2024

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Inactive for 60 days label Oct 6, 2024
@joshua-kim joshua-kim added lifecycle/frozen and removed lifecycle/stale Inactive for 60 days labels Oct 9, 2024
joshua-kim added 3 commits June 5, 2025 22:18
@joshua-kim
lint
3debf85 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
nit
8bdf104 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
rename to ping
617e56f 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim joshua-kim changed the title Add support for VM gRPC services Add support for VM HTTP2 handlers Jun 6, 2025
@joshua-kim joshua-kim changed the title Add support for VM HTTP2 handlers Add support for VM Http2 handlers Jun 6, 2025
joshua-kim added 2 commits June 5, 2025 23:34
@joshua-kim
godoc
0c32bb3 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
rename
151dabb 
Signed-off-by: Joshua Kim <[email protected]>
StephenButtolph
StephenButtolph reviewed Jun 6, 2025
View reviewed changes
Comment thread vms/example/xsvm/api/ping.go Outdated
Comment thread api/server/http2_router.go Outdated
Comment thread api/server/http2_router.go Outdated
Comment thread api/server/http2_router.go Outdated
Comment thread api/server/http2_router_test.go Outdated
Comment thread api/server/http2_router_test.go Outdated
Comment thread api/server/server.go
Comment thread api/server/server.go Outdated
Comment thread vms/example/xsvm/vm.go Outdated
Comment thread vms/rpcchainvm/vm_server.go Outdated
joshua-kim and others added 9 commits June 6, 2025 11:28
@joshua-kim @StephenButtolph
Update api/server/http2_router.go
eae409c 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim @StephenButtolph
Update api/server/http2_router_test.go
7b1e4ef 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim @StephenButtolph
Update vms/example/xsvm/vm.go
7bbe431 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim @StephenButtolph
Update vms/rpcchainvm/vm_server.go
c3ecc03 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim @StephenButtolph
Update api/server/http2_router_test.go
c40bfd6 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim @StephenButtolph
Update api/server/http2_router.go
c582e36 
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
remove wrapping layer
2b3a8e3 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
move locking
d18fe88 
Signed-off-by: Joshua Kim <[email protected]>
@joshua-kim
add logging
5878bee 
Signed-off-by: Joshua Kim <[email protected]>
@StephenButtolph StephenButtolph added this pull request to the merge queue Jun 6, 2025
@StephenButtolph StephenButtolph removed this pull request from the merge queue due to a manual request Jun 6, 2025
@StephenButtolph StephenButtolph changed the title Add support for VM Http2 handlers Add support for VM HTTP2 handlers Jun 6, 2025
@joshua-kim
Copy link
Copy Markdown
Contributor Author

joshua-kim commented Jun 6, 2025

Related coreth pr ava-labs/coreth#1006

@joshua-kim
update coreth
bcb1f42 
Signed-off-by: Joshua Kim <[email protected]>
@StephenButtolph StephenButtolph added this pull request to the merge queue Jun 6, 2025
Merged via the queue into master with commit 3ee09b9 Jun 6, 2025
28 checks passed
@StephenButtolph StephenButtolph deleted the cmux branch June 6, 2025 18:08
@github-project-automation github-project-automation bot moved this from Ready 🚦 to Done 🎉 in avalanchego Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yacovm yacovm yacovm left review comments

@StephenButtolph StephenButtolph StephenButtolph approved these changes

@maru-ava maru-ava maru-ava approved these changes

+1 more reviewer

@marun marun marun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joshua-kim joshua-kim

Labels

enhancement New feature or request

Projects

avalanchego
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshua-kim @marun @yacovm @StephenButtolph @maru-ava