Handle DatasetDict in clean_and_validate_predictions
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
force-pushed
the
handle-ds-dict
branch
from
b126064 to
1952543
Compare
abdulfatir
changed the title
DatasetDict in _clean_and_validate_predictionsDatasetDict in clean_and_validate_predictions
shchur
reviewed
Jun 4, 2025
| ) | ||
| else: | ||
| predictions = datasets.DatasetDict({self.target_column: _to_dataset(predictions)}) | ||
| predictions = datasets.DatasetDict({self.target_column: _to_dataset(predictions)}) |
Contributor
There was a problem hiding this comment.
Could you also add a new test case or extend an existing test in https://github.com/autogluon/fev/blob/main/test/test_task.py to ensure that all prediction formats work with both univariate and multivariate tasks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This PR handles the case where
predictionsare alreadyDatasetDict. Previously, it broke for univariate tasks if the predictionswere alreadyDatasetDict`.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.