[timeseries] Fix ensemble weights format for printing #5132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
approved these changes
May 20, 2025
| self.model_to_weight[model_name] = weight | ||
|
|
||
| weights_for_printing = {model: round(weight, 2) for model, weight in self.model_to_weight.items()} | ||
| weights_for_printing = {model: round(float(weight), 2) for model, weight in self.model_to_weight.items()} |
Collaborator
There was a problem hiding this comment.
The nittest of picks: Not sure if weight.item() is better than casting.
Collaborator
Author
There was a problem hiding this comment.
I think float(something) is slightly better here because it will work even if the weight values have type float (and not np.float64).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
numpy>2.0the ensemble weights are printed as follows:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.