Fix source installation issue on colab #4964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 626abf7.
Innixma
reviewed
Mar 6, 2025
Comment on lines
4
to
9
| # Get the directory of the script | ||
| script_dir=$(dirname "$0") | ||
|
|
||
| # Change the current directory to the script's directory | ||
| cd "$script_dir" | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe instead we only do this logic if not in a colab environment, instead of removing it?
Alternative, don't remove it, but if colab, force --non-editable flag setting. This should also fix the issue, since there is no need to have editable install in colab.
…luon#4933)"" This reverts commit 0e03412.
tonyhoo
changed the title
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
/platform_tests 448150b |
Innixma
reviewed
Mar 11, 2025
full_install.sh
Outdated
| echo "Colab detected - forcing non-editable install" | ||
| else | ||
| EDITABLE="true" | ||
| cd "$script_dir" |
Contributor
There was a problem hiding this comment.
can we try moving the cd "$script_dir" outside of the if/else, so it always happens? This should fix the below:
Ideally this should work in colab:
!git clone -b revert_change https://github.com/tonyhoo/autogluon.git
!./autogluon/full_install.sh
But it doesn't currently:
error: Distribution not found at: file:///content/common
Contributor
Author
|
/platform_tests 5ea605f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 626abf7.
Issue #, if available:
N/A
Description of changes:
Reverting changes to
full_install.shthat addedcd "$script_dir". This change caused problems with editable installations in Colab environments, where the src-layout structure combined with changing directories resulted in Python being unable to find the correct modules.The revert ensures that users installing AutoGluon from source in Colab can properly import modules like
TabularPredictorwithout additional workarounds. This issue primarily affects researchers and developers who install from source in notebook environments.Testing verified at: Colab
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.