[tabular] Add raise_on_model_failure flag #4937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
canerturkmen
left a comment
canerturkmen
left a comment
There was a problem hiding this comment.
LGTM overall. I would only encourage adding tests. If somebody else decides to catch the model errors (i.e., the learner starts catching stuff), the behavior will break.
| This is useful when using a debugger during development to identify the cause of model failures. | ||
| This should only be used for debugging. | ||
| If False, will try to skip to the next model if an exception occurred during model training. | ||
| This is the default logic and is a core principal of AutoGluon's design. |
canerturkmen
approved these changes
Feb 26, 2025
Contributor
Author
|
added unit test, good suggestion @canerturkmen ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.