-
Notifications
You must be signed in to change notification settings - Fork 1.1k
update sagemaker base images to use pytorch 2.2 #4256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does torchaudio get installed along with torch?
or is it separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torchaudio is included in the sagemaker base image, previously we had the sagemaker torch 2.1 base image, so everything related to torch installs 2.1, but since our master is already installing torch 2.2 by default, and we don't install torchaudio, torchaudio stays at 2.1.x. Somehow it's causing issues when I ran the tests in AutoGluon Cloud https://github.com/autogluon/autogluon-cloud/actions/runs/9456879067/job/26091603325
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, so how is it resolved just by updating to torch 2.2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sagemaker torch 2.2 base image would align with AG's torch version 2.2 and installs torchaudio 2.2.x, so that torchaudio would also be compatible with other torch modules.
Issue #, if available:
Description of changes:
The original pytorch2.1 sagemaker base images installs
torchaudio2.1.x, however, AutoGluon master installstorch2.2.x will introduce incompatibility issues. Updating the sagemaker base image version would resolve this issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.