Skip to content

Conversation

@Innixma
Copy link
Contributor

@Innixma Innixma commented Jun 6, 2024

Issue #, if available:

Description of changes:

  • Make AsType exception logging handle all exception types, instead of just ValueError. For example, NaNs can lead to exceptions types such as IntCastingNaNError, which previously wouldn't benefit from the improved exception logging.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Innixma Innixma added API & Doc Improvements or additions to documentation module: features labels Jun 6, 2024
@Innixma Innixma added this to the 1.1.1 Release milestone Jun 6, 2024
@Innixma Innixma requested a review from rey-allan June 6, 2024 23:00
Copy link
Contributor

@rey-allan rey-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yinweisu
Copy link
Contributor

yinweisu commented Jun 6, 2024

Previous CI Run Current CI Run

@Innixma Innixma merged commit a715fe5 into autogluon:master Jun 6, 2024
@Innixma Innixma deleted the make_astype_exception_more_general branch April 16, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API & Doc Improvements or additions to documentation module: features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants