Skip to content

[timeseries] Use correct target and quantile_levels in fallback model for MLForecast #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shchur merged 1 commit into from
May 28, 2024
Merged

[timeseries] Use correct target and quantile_levels in fallback model for MLForecast #4230

shchur merged 1 commit into from
May 28, 2024

Conversation

@shchur
Copy link
Collaborator

@shchur shchur commented May 28, 2024

Description of changes:

  • Make sure that the fallback model uses the correct values for target and quantile_levels.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shchur shchur added bug Something isn't working module: timeseries related to the timeseries module labels May 28, 2024
@shchur shchur added this to the 1.1.1 Release milestone May 28, 2024
@shchur shchur requested a review from canerturkmen May 28, 2024 07:50
canerturkmen
canerturkmen approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yinweisu
Copy link
Contributor

yinweisu commented May 28, 2024

Previous CI Run Current CI Run
botocore==1.34.112 botocore==1.34.113
fastcore==1.5.38 fastcore==1.5.40
huggingface-hub==0.23.1 huggingface-hub==0.23.2
types-setuptools==70.0.0.20240523 types-setuptools==70.0.0.20240524
boto3==1.34.112 boto3==1.34.113
prompt-toolkit==3.0.43 -
fonttools==4.51.0 fonttools==4.52.4
botocore==1.34.112 botocore==1.34.113
fastcore==1.5.38 fastcore==1.5.40
huggingface-hub==0.23.1 huggingface-hub==0.23.2
types-setuptools==70.0.0.20240523 types-setuptools==70.0.0.20240524
boto3==1.34.112 boto3==1.34.113
- prompt_toolkit==3.0.44
fonttools==4.51.0 fonttools==4.52.4

@shchur shchur merged commit 8dbfe06 into autogluon:master May 28, 2024
@shchur shchur deleted the fallback-model-fix-mlforecast branch May 28, 2024 09:26
@github-actions
Copy link

github-actions bot commented May 28, 2024

Job PR-4230-bd5aedf is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4230/bd5aedf/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canerturkmen canerturkmen canerturkmen approved these changes

Assignees

No one assigned

Labels

bug Something isn't working module: timeseries related to the timeseries module

Projects

None yet

Milestone

1.1.1 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@shchur @yinweisu @canerturkmen