Skip to content

Conversation

@shchur
Copy link
Collaborator

@shchur shchur commented May 4, 2024

Issue #, if available: Fixes #4133

Description of changes:

  • Fix loading of Tabular models failing if predictor moved to a different directory. Now the path of the Tabular predictor is generated at runtime based on the model path.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shchur shchur requested a review from canerturkmen May 4, 2024 17:37
@shchur shchur added this to the 1.1.1 Release milestone May 4, 2024
@shchur shchur added module: timeseries related to the timeseries module bug Something isn't working labels May 4, 2024
@yinweisu
Copy link
Contributor

yinweisu commented May 4, 2024

Previous CI Run Current CI Run
Pygments==2.17.2 Pygments==2.18.0
cryptography==42.0.5 cryptography==42.0.6
Pygments==2.17.2 Pygments==2.18.0
cryptography==42.0.5 cryptography==42.0.6

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Made some comments.

@yinweisu
Copy link
Contributor

yinweisu commented May 7, 2024

Previous CI Run Current CI Run

@shchur shchur force-pushed the fix-ts-tabular-path branch from 1721730 to 73c1dc2 Compare May 7, 2024 13:58
@yinweisu
Copy link
Contributor

yinweisu commented May 7, 2024

Previous CI Run Current CI Run

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shchur shchur merged commit 309a58e into autogluon:master May 7, 2024
@shchur shchur deleted the fix-ts-tabular-path branch May 7, 2024 16:16
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working module: timeseries related to the timeseries module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TimeSeriesPredictor loading from different path than originally saved in fails for tabular predictors

3 participants