-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[tabular] Add "auto" option for calibrate_decision_threshold #4137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Innixma
merged 5 commits into
autogluon:master
from
Innixma:calibrate_decision_threshold_auto
Apr 25, 2024
Merged
[tabular] Add "auto" option for calibrate_decision_threshold #4137
Innixma
merged 5 commits into
autogluon:master
from
Innixma:calibrate_decision_threshold_auto
Apr 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
|
rey-allan
approved these changes
Apr 24, 2024
Contributor
rey-allan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Contributor
|
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
needs_classproperty). This is important because while we technically can run metrics like root_mean_squared_error through decision_threshold_calibration and not crash, it would not lead to the intended functionality. Withneeds_class, we know that RMSE is not valid for threshold calibration and avoid it whencalibrate_decision_threshold="auto".calibrate_decision_thresholdto"auto"as the new default in TabularPredictor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.