[tabular] Add secondary_decision_thresholds to calibrate_decision_threshold #4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
rey-allan
approved these changes
Apr 24, 2024
Contributor
rey-allan
left a comment
rey-allan
left a comment
There was a problem hiding this comment.
Ship it!
For visibility, had a discussion with Nick offline re:making it more generic and allowing users to specify the number of calibration phases. We agreed that having more than 2 phases would lead to searching spaces that are too small. This would increase time without really adding any benefit to performance.
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds
secondary_decision_thresholdsargument to decision threshold calibration.This enables a 2nd-round fine-grained search of the optimal threshold.
In total this is 25% faster with 10x finer granularity than the previous implementation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.