Upgrade pandas supported range to >=2.0, <2.3 #4079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/platform_tests ref=pandas-2.2 |
Contributor
|
1 similar comment
Contributor
|
Collaborator
Author
|
/platform_tests ref=pandas-2.2 |
Contributor
|
Contributor
|
/platform_tests ref=pandas-2.2 |
Collaborator
Author
|
/platform_tests ref=pandas-2.2 |
Contributor
|
shchur
changed the title
shchur
commented
Apr 11, 2024
|
|
||
| # Have to convert to object dtype because category dtype for unknown reasons will refuse to replace NaNs. | ||
| # TODO: Fix FutureWarning | ||
| X_cur = X[features_to_check].astype("object").replace(mapping_features_val_dict_cur).astype(np.int64) |
Collaborator
Author
There was a problem hiding this comment.
@Innixma this line raises FutureWarning:
/local/home/shchuro/workspace/autogluon/features/src/autogluon/features/generators/drop_duplicates.py:135: FutureWarning: Downcasting behavior in `r
eplace` is deprecated and will be removed in a future version. To retain the old behavior, explicitly call `result.infer_objects(copy=False)`. To opt-
in to the future behavior, set `pd.set_option('future.no_silent_downcasting', True)`
X_cur = X[features_to_check].astype("object").replace(mapping_features_val_dict_cur).astype(np.int64)
Do you have any recommendations on how to fix it while keeping the correct behavior in pandas 2.0/2.1/2.2?
Contributor
There was a problem hiding this comment.
will investigate and send PR
Contributor
|
| "min": "T", | ||
| "ms": "L", | ||
| "us": "U", | ||
| # sub-daily |
zhiqiangdon
reviewed
Apr 11, 2024
Contributor
zhiqiangdon
left a comment
zhiqiangdon
left a comment
There was a problem hiding this comment.
May not have enough time to test this before 1.1 release.
Innixma
approved these changes
Apr 11, 2024
Contributor
Innixma
left a comment
Innixma
left a comment
There was a problem hiding this comment.
LGTM! Will do follow-up PRs to addres FutureWarnings
This was referenced Apr 11, 2024
Closed
Closed
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3989
Description of changes:
YEinstead ofAin our code).W) that are compatible with both old/new style, and take care of all the frequency-related logic in AutoGluon (e.g., time features, lag selection)>=0.14.0,<0.14.4to ensure that pandas 2.2 can be installedCategoryFeatureGeneratorTesting:
To do:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.