Skip to content

Conversation

@canerturkmen
Copy link
Contributor

@canerturkmen canerturkmen commented Mar 13, 2024

Issue #, if available:

Description of changes:

Add Chronos, a pretrained time series model for forecasting.

Remaining todos:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and thanks for the amazing CPU inference speed optimizations!

My main question is related to merging skip_validation and disable_length_check kwargs, the rest are minor comments.

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
numba==0.59.0 numba==0.59.1
numba==0.59.0 numba==0.59.1

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
botocore==1.34.65 botocore==1.34.66
boto3==1.34.65 boto3==1.34.66
botocore==1.34.65 botocore==1.34.66
boto3==1.34.65 boto3==1.34.66

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks from my side, I think we are almost there. Also the tests are a work of art 💪

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@canerturkmen
Copy link
Contributor Author

/platform_tests ref=add-chronos

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
graphviz==0.20.2 graphviz==0.20.3
graphviz==0.20.2 graphviz==0.20.3

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@canerturkmen canerturkmen force-pushed the add-chronos branch 2 times, most recently from 9423a05 to ed0aa01 Compare March 21, 2024 16:40
@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run

@canerturkmen canerturkmen marked this pull request as ready for review March 21, 2024 19:02
@canerturkmen
Copy link
Contributor Author

@shchur Ready for your final review! 🚀

@yinweisu
Copy link
Contributor

Previous CI Run Current CI Run
typer==0.9.0 typer==0.9.4
typer==0.9.0 typer==0.9.4

Copy link
Collaborator

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@shchur shchur merged commit c53adef into autogluon:master Mar 24, 2024
@canerturkmen canerturkmen deleted the add-chronos branch March 25, 2024 09:09
LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: timeseries related to the timeseries module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants