-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[timeseries] Add Chronos pretrained forecasting model #3978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad321d2 to
436078b
Compare
shchur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and thanks for the amazing CPU inference speed optimizations!
My main question is related to merging skip_validation and disable_length_check kwargs, the rest are minor comments.
|
|
|
|
shchur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpicks from my side, I think we are almost there. Also the tests are a work of art 💪
|
Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Oleksandr Shchur <[email protected]>
8f8711a to
ed0aa01
Compare
|
|
/platform_tests ref=add-chronos |
|
|
9423a05 to
ed0aa01
Compare
|
|
|
@shchur Ready for your final review! 🚀 |
|
shchur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Oleksandr Shchur <[email protected]>
Issue #, if available:
Description of changes:
Add Chronos, a pretrained time series model for forecasting.
Remaining todos:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.