fix: schema compilation (#612) #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 41.18% 41.35% +0.16%
==========================================
Files 38 38
Lines 4987 4998 +11
==========================================
+ Hits 2054 2067 +13
Misses 2684 2684
+ Partials 249 247 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
fix-schema-compile-and-write
branch
from
1604df9 to
c089234
Compare
tstirrat15
approved these changes
Dec 29, 2025
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
Seems fine but see comment
Comment on lines
-371
to
-372
| if outputFilepath == "" && !termChecker.IsTerminal(stdOutFd) { | ||
| return errors.New("must provide stdout or output file path") |
Contributor
There was a problem hiding this comment.
If we don't have this do we get weird behavior in environments that don't have stdout available? Or is that captured by the error behavior of writing to os.Stdout?
Contributor
Author
There was a problem hiding this comment.
I think it's captured by the call to fmt.Fprint.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the command works correctly in all scenarios:
zed schema compile file.zed→ writes to stdoutzed schema compile file.zed 1> out.txt→ writes to redirected stdoutzed schema compile file.zed --out out.txt→ writes to specified filePreviously, number 2 didn't work.