Skip to content

fix: backup relationships with expiration #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miparnisari merged 1 commit into from
Dec 29, 2025
Merged

fix: backup relationships with expiration #611

miparnisari merged 1 commit into from
Dec 29, 2025

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Dec 28, 2025 •
edited
Loading

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.18%. Comparing base (b70afd0) to head (2830a82).

Files with missing lines Patch % Lines
pkg/backupformat/schema.go 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   41.06%   41.18%   +0.11%     
==========================================
  Files          38       38              
  Lines        4977     4987      +10     
==========================================
+ Hits         2044     2054      +10     
  Misses       2684     2684              
  Partials      249      249

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@miparnisari miparnisari marked this pull request as ready for review December 28, 2025 20:40
tstirrat15
tstirrat15 approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit 74c5e66 into main Dec 29, 2025
12 checks passed
@miparnisari miparnisari deleted the backup-expirations branch December 29, 2025 03:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miparnisari @codecov-commenter @tstirrat15