Skip to content

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Dec 2, 2025

Fixes #590

Description

See #590. We updated how recursion depth limits show up, so we're making updates here as well. There aren't as many of them as I would have thought.

Changes

  • Update test

Testing

Review.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.68%. Comparing base (7ed5ab0) to head (b48e25a).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   39.28%   41.68%   +2.40%     
==========================================
  Files          37       37              
  Lines        5448     4764     -684     
==========================================
- Hits         2140     1986     -154     
+ Misses       3063     2519     -544     
- Partials      245      259      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15 tstirrat15 force-pushed the 590-recursion-depth-error-handling branch from b48e25a to 62d6142 Compare December 2, 2025 20:39
@tstirrat15 tstirrat15 enabled auto-merge (squash) December 2, 2025 20:39
@tstirrat15 tstirrat15 merged commit 6e8943e into main Dec 2, 2025
11 checks passed
@tstirrat15 tstirrat15 deleted the 590-recursion-depth-error-handling branch December 2, 2025 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update recursion depth checking logic to reflect new gRPC code in SpiceDB

4 participants