Skip to content

added a verbose message for keyring error #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tstirrat15 merged 1 commit into from
Aug 21, 2025
Merged

added a verbose message for keyring error #533

tstirrat15 merged 1 commit into from
Aug 21, 2025

Conversation

@sohanmaheshwar
Copy link
Contributor

@sohanmaheshwar sohanmaheshwar commented Aug 1, 2025

Description

When a system doesn't have a native keyring manager, this is what the current error message is:

Setting the environment variable `ZED_KEYRING_PASSWORD` to your password will skip prompts.
Keyring file does not already exist.
Enter a new non-empty passphrase for the new keyring file:

This doesn't explain why this error is popping up, so i've added a line for more details about it. The new message will read:

If your platform doesn't have a native keychain manager (e.g. macOS, Linux+GNOME/KDE), ZED_KEYRING_PASSWORD is what's used to encrypt files on disk to store credentials. The first time you create a context, it'll prompt you to create a keyring password to encrypt that configuration.
Keyring file does not already exist.
Enter a new non-empty passphrase for the new keyring file:

It's a bit more verbose, but provides more context.

Testing

Tried zed context on the Instruqt platform VM which didn't have a native keyring manger and saw this message.

References

@sohanmaheshwar
Copy link
Contributor Author

sohanmaheshwar commented Aug 1, 2025

Feel free to edit the error message too

tstirrat15
tstirrat15 approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Thank you!

@tstirrat15 tstirrat15 merged commit 8d66f91 into authzed:main Aug 21, 2025
15 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

@jzelinskie jzelinskie Awaiting requested review from jzelinskie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sohanmaheshwar @tstirrat15