Skip to content

chore: implement self in schemav2#2887

Merged
tstirrat15 merged 1 commit intomainfrom
add-self-to-schema-v2-to-v1
Feb 6, 2026
Merged

chore: implement self in schemav2#2887
tstirrat15 merged 1 commit intomainfrom
add-self-to-schema-v2-to-v1

Conversation

@tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Feb 6, 2026

Description

A package that uses SpiceDB had failing tests because of this missing functionality. This fixes that.

Changes

  • Add tests for use self
  • Fix tests

Testing

Review. See that tests pass.

@tstirrat15 tstirrat15 requested a review from a team as a code owner February 6, 2026 19:02
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.86%. Comparing base (7f9bd27) to head (6ef8f97).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/schema/arrows.go 0.00% 1 Missing ⚠️
pkg/schema/full_reachability.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (74.86%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2887       +/-   ##
===========================================
+ Coverage   50.19%   74.86%   +24.67%     
===========================================
  Files         416      484       +68     
  Lines       51935    58060     +6125     
===========================================
+ Hits        26064    43459    +17395     
+ Misses      23255    11553    -11702     
- Partials     2616     3048      +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

miparnisari
miparnisari previously approved these changes Feb 6, 2026
@tstirrat15 tstirrat15 force-pushed the add-self-to-schema-v2-to-v1 branch 2 times, most recently from 35f2f8d to b1f1cdd Compare February 6, 2026 19:28
josephschorr
josephschorr previously approved these changes Feb 6, 2026
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 force-pushed the add-self-to-schema-v2-to-v1 branch from dfb1ef7 to 6ef8f97 Compare February 6, 2026 19:56
@tstirrat15 tstirrat15 merged commit d842a97 into main Feb 6, 2026
43 of 45 checks passed
@tstirrat15 tstirrat15 deleted the add-self-to-schema-v2-to-v1 branch February 6, 2026 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants