fix: handle self keyword in warnings checks, and check these warnings are error-free in consistency#2884
Merged
tstirrat15 merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
github-actions
bot
added
the
area/tooling
miparnisari
reviewed
Feb 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.88%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2884 +/- ##
==========================================
+ Coverage 74.86% 74.88% +0.02%
==========================================
Files 484 484
Lines 57994 57996 +2
==========================================
+ Hits 43413 43426 +13
+ Misses 11544 11535 -9
+ Partials 3037 3035 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…gs are error-free in consistency
barakmich
force-pushed
the
barakmich/warnings
branch
from
b102f4b to
1f7b1a9
Compare
miparnisari
previously approved these changes
Feb 5, 2026
barakmich
dismissed stale reviews from miparnisari and tstirrat15
via
5c158ac
miparnisari
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
References