Skip to content

feat: finish LR consistency tests with the fix to the recursive iterator#2881

Merged
barakmich merged 4 commits intomainfrom
barakmich/lr_recursive
Feb 5, 2026
Merged

feat: finish LR consistency tests with the fix to the recursive iterator#2881
barakmich merged 4 commits intomainfrom
barakmich/lr_recursive

Conversation

@barakmich
Copy link
Contributor

Using the RecursiveSentinel as the stand in for each ply of the transitive closure

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 5, 2026 00:13
@barakmich barakmich force-pushed the barakmich/lr_recursive branch from a51fdbb to 1e61428 Compare February 5, 2026 00:15
tstirrat15
tstirrat15 previously approved these changes Feb 5, 2026
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 76.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.88%. Comparing base (208ad95) to head (40e19b6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/recursive.go 76.00% 13 Missing and 5 partials ⚠️

❌ Your project status has failed because the head coverage (74.88%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   74.88%   74.88%   +0.01%     
==========================================
  Files         484      484              
  Lines       57938    57994      +56     
==========================================
+ Hits        43380    43424      +44     
- Misses      11527    11532       +5     
- Partials     3031     3038       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 5, 2026
@barakmich barakmich force-pushed the barakmich/lr_recursive branch from 9e5e731 to 0ae0259 Compare February 5, 2026 17:38
@barakmich barakmich force-pushed the barakmich/lr_recursive branch from 0ae0259 to 40e19b6 Compare February 5, 2026 17:52
@barakmich barakmich enabled auto-merge (squash) February 5, 2026 18:15
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGGTM

@barakmich barakmich merged commit 03a3a18 into main Feb 5, 2026
74 of 78 checks passed
@barakmich barakmich deleted the barakmich/lr_recursive branch February 5, 2026 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants