fix: prevent panic on malformed cursor#2878
Merged
tstirrat15 merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
github-actions
bot
added
the
area/tooling
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (74.82%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2878 +/- ##
==========================================
+ Coverage 74.79% 74.82% +0.03%
==========================================
Files 484 484
Lines 57786 57789 +3
==========================================
+ Hits 43217 43233 +16
+ Misses 11550 11537 -13
Partials 3019 3019 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
barakmich
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user reported that a malformed cursor string could cause a panic which could bring down the SpiceDB process. This fixes that problem.
Changes
Parseinstead ofMustParseTesting
Review.