Skip to content

fix: improve LR consistency and support multiple resourcetypes#2875

Merged
barakmich merged 5 commits intomainfrom
barakmich/lr_fixes_1
Feb 4, 2026
Merged

fix: improve LR consistency and support multiple resourcetypes#2875
barakmich merged 5 commits intomainfrom
barakmich/lr_fixes_1

Conversation

@barakmich
Copy link
Contributor

@barakmich barakmich commented Feb 3, 2026

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 3, 2026 21:36
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 68.13187% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.81%. Comparing base (fa1d7f4) to head (4a137a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/intersection.go 51.73% 10 Missing and 4 partials ⚠️
pkg/query/alias.go 46.67% 6 Missing and 2 partials ⚠️
pkg/query/datastore.go 57.15% 3 Missing ⚠️
pkg/query/self.go 76.93% 2 Missing and 1 partial ⚠️
pkg/query/union.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
- Coverage   74.83%   74.81%   -0.02%     
==========================================
  Files         484      484              
  Lines       57789    57828      +39     
==========================================
+ Hits        43242    43256      +14     
- Misses      11532    11548      +16     
- Partials     3015     3024       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tstirrat15
tstirrat15 previously approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments

@barakmich barakmich force-pushed the barakmich/lr_fixes_1 branch from a772763 to 4a137a7 Compare February 4, 2026 22:21
tstirrat15
tstirrat15 approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@barakmich barakmich enabled auto-merge (squash) February 4, 2026 22:50
@barakmich barakmich merged commit c2c3bab into main Feb 4, 2026
75 of 78 checks passed
@barakmich barakmich deleted the barakmich/lr_fixes_1 branch February 4, 2026 22:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees

No one assigned

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barakmich @tstirrat15