fix: update IterSubjects for wildcards and Alias iterators for confomance#2864
fix: update IterSubjects for wildcards and Alias iterators for confomance#2864
Conversation
github-actions
bot
added
the
area/tooling
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (74.33%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
- Coverage 74.41% 74.33% -0.07%
==========================================
Files 484 484
Lines 57792 57786 -6
==========================================
- Hits 43000 42950 -50
- Misses 11771 11812 +41
- Partials 3021 3024 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
barakmich
force-pushed
the
barakmich/ls_wildcard_alias
branch
from
b30a132 to
1525e5b
Compare
barakmich
force-pushed
the
barakmich/ls_wildcard_alias
branch
from
1525e5b to
75bf1a6
Compare
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
Boy these are weird. I appreciate the way you documented them and tested them.
| return | ||
| } | ||
| iter, err := ctx.Reader.QueryRelationships(ctx, filter, | ||
| options.WithLimit(options.LimitOne), |
There was a problem hiding this comment.
Wow, so the check logic is conditionally running to the datastore like this? Or is this more an artifact of the query planner having a different structure?
There was a problem hiding this comment.
More the different structure. Whereas in other LS implementations we just fetch where necessary, and in QP we've tried to keep it at the leaves. Unfortunately, this is something where the semantics break the expectation 😞
| // subjects as the non-wildcard branch (when both wildcard and concrete relationships exist), | ||
| // but the Union will deduplicate them. | ||
| // | ||
| // Note: We query for all subjects of the appropriate type, not just those with a relationship |
There was a problem hiding this comment.
Wow... this feels kinda wild.
barakmich
force-pushed
the
barakmich/ls_wildcard_alias
branch
from
75bf1a6 to
deb1327
Compare
2 participants
Description
Testing
References