Repository navigation
Return an empty list for an empty query string - #926
Merged
Merged
Conversation
extract_params documents that empty strings, dicts and lists all give back an empty list of parameters. The dict and list cases do; the empty string fell through to a truthiness guard and returned None instead. url_decode already returns [] for an empty string, so the guard only needed to be about the type rather than the value. Every caller inside authlib writes extract_params(body) or [], which works either way.
Contributor
Author
|
Hi, just checking in on this one. It's still mergeable and the tests pass. Happy to change anything if needed. |
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_paramsdocuments that empty strings, dicts and lists all give back an empty list of parameters:The dict and list cases do. The empty string falls through to a truthiness guard and returns
Noneinstead.url_decode("")already returns[], so the guard only needed to be about the type rather than the value. Every caller inside authlib writesextract_params(body) or [], which works either way.Reverting the change fails the three new tests