Client id_token_signed_response_alg metadata takes precedence over server get_jwt_config#843
Closed
azmeuk wants to merge 1 commit intoauthlib:mainfrom
Closed
Client id_token_signed_response_alg metadata takes precedence over server get_jwt_config#843azmeuk wants to merge 1 commit intoauthlib:mainfrom
id_token_signed_response_alg metadata takes precedence over server get_jwt_config#843azmeuk wants to merge 1 commit intoauthlib:mainfrom
Conversation
…er server get_jwt_config
Member
Author
|
Actually I will do it in a way that does not bring a breaking change. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
When signing id_tokens, the client
id_token_signed_response_algmetadata is used in priority.Fixes #806.
Does this PR introduce a breaking change?
Before this, the value defined in
get_jwt_configwas used in priority, andid_token_signed_response_algwas only used ifget_jwt_configdoes not providealg.This should only be merged for 1.7