Sign OIDC id_token according to id_token_signed_response_alg client metadata#802
Merged
lepture merged 1 commit intoauthlib:mainfrom Aug 26, 2025
Merged
Conversation
…g client metadata
8665d3f to
86b1b78
Compare
lepture
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The behavior to find the
algwith which the id_token is signed is:algis set inget_jwt_configif definedclient.id_token_signed_response_algif definedRS256I think
client.id_token_signed_response_algshould take precedence overget_jwt_config, but that would be a breaking change. I will open another ticket for that, this could target v1.8.Working on this part of the code made me realize that he
get_jwt_configmight be a little outdated. We would probably want useget_server_jwksinstead here, instead of manually passing a key. What do you think?fixes #755
Checklist
pre-commit.