Conversation
azmeuk
reviewed
Jul 24, 2025
Member
azmeuk
left a comment
azmeuk
left a comment
There was a problem hiding this comment.
LGTM, some little things:
- The tests don't check for the
missing_codestring. - The MissingCode exception could have a more explicit description.
azmeuk
approved these changes
Aug 6, 2025
Member
azmeuk
left a comment
azmeuk
left a comment
There was a problem hiding this comment.
I added the missing tests. This is all good now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #777
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
This affect the OAuth 2 framework clients authorize access token flow.